Github user nkalmar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/542#discussion_r196062698
--- Diff:
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -686,6 +686,8 @@ public void configure(InetSocketAddress addr, int
maxcc, boolean secure) throws
LOG.info("binding to port " + addr);
ss.socket().bind(addr);
ss.configureBlocking(false);
+ int port = ss.socket().getLocalPort();
+ LOG.info("bound to port " + port);
--- End diff --
Just a nitpick: why create a variable for the port?
---