[
https://issues.apache.org/jira/browse/ZOOKEEPER-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar updated ZOOKEEPER-3065:
------------------------------------
Description:
The following issues would be nice to address:
* Tests cover addresses with IP addresses only, a few of them test unresolved
hostnames, but ideal would be to create Test parameters and run all tests for
both cases,
* Test methods should be split into multiple to cover one test case / test
method,
* Style: instead of assertTrue(a < b), we should use assertThat(b,
greaterThan(a))
* Extract redundant code snippets into methods
was:
The following issues would be nice to address:
* Tests over addresses with IP addresses only, a few of them test unresolved
hostnames, but ideal would be to create Test parameters and run all tests for
both cases,
* Test methods should be split into multiple to cover one test case / test
method,
* Style: instead of assertTrue(a < b), we should use assertThat(b,
greaterThan(a))
* Extract redundant code snippets into methods
> Refactor existing reconfig tests in StaticHostProviderTest
> ----------------------------------------------------------
>
> Key: ZOOKEEPER-3065
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3065
> Project: ZooKeeper
> Issue Type: Test
> Components: tests
> Affects Versions: 3.6.0
> Reporter: Andor Molnar
> Assignee: Andor Molnar
> Priority: Minor
> Fix For: 3.6.0
>
>
> The following issues would be nice to address:
> * Tests cover addresses with IP addresses only, a few of them test
> unresolved hostnames, but ideal would be to create Test parameters and run
> all tests for both cases,
> * Test methods should be split into multiple to cover one test case / test
> method,
> * Style: instead of assertTrue(a < b), we should use assertThat(b,
> greaterThan(a))
> * Extract redundant code snippets into methods
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)