Github user nkalmar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/547#discussion_r197724069
--- Diff: src/c/src/zookeeper.c ---
@@ -4358,7 +4358,9 @@ static const char* format_endpoint_info(const struct
sockaddr_storage* ep)
{
static char buf[128] = { 0 };
char addrstr[128] = { 0 };
+ const char *fmtstring;
void *inaddr;
+ int inet6 = 0; // poor man's boolean
--- End diff --
Just a nitpick for future readability - Maybe just java speaking from me,
but why not use some more clear name like is_inet6?
(Or include stdbool)
---
