Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/548#discussion_r201926608
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -857,15 +869,15 @@ public void run() {
self.recreateSocketAddresses(self.getId());
addr = self.getElectionAddress();
}
- LOG.info("My election bind port: " + addr.toString());
+ LOG.info("My election bind port: " +
formatInetAddr(addr));
setName(addr.toString());
--- End diff --
using `toString` can still distinguish ipv4 from ipv6 by looking at the ip
style although without `[] `
if `formatInetAddr(addr)` is really needed, can you make sure all the
places which log `InetSocketAddress` are covered?
---
