Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/566#discussion_r202508017
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -339,7 +342,8 @@ public synchronized void commit() throws IOException {
+ Thread.currentThread().getName()
+ " took " + syncElapsedMS
+ "ms which will adversely effect operation
latency. "
- + "File size is " + channel.size() + " bytes. "
+ + "File size is " + channel.size() + " bytes
and "
--- End diff --
It's cleaner to change the logger format to using placeholder with {}.
---
