Github user breed commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/555#discussion_r205669958
  
    --- Diff: 
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java ---
    @@ -792,7 +792,14 @@ public boolean syncFollower(long peerLastZxid, 
ZKDatabase db, Leader leader) {
                         txnProposalItr.close();
                     }
                 } else {
    -                LOG.warn("Unhandled scenario for peer sid: " +  getSid());
    +                LOG.warn("Unhandled scenario for peer sid: {} 
maxCommittedLog=0x{}"
    --- End diff --
    
    the logging levels are different, and it is nice to have the evaluation 
information with weird corner case scenario. i think it's worth surfacing the 
information here as well.


---

Reply via email to