Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/587#discussion_r207613222
--- Diff:
src/java/main/org/apache/zookeeper/client/ConnectStringParser.java ---
@@ -68,14 +69,26 @@ public ConnectStringParser(String connectString) {
List<String> hostsList = split(connectString,",");
for (String host : hostsList) {
int port = DEFAULT_PORT;
- int pidx = host.lastIndexOf(':');
- if (pidx >= 0) {
- // otherwise : is at the end of the string, ignore
- if (pidx < host.length() - 1) {
- port = Integer.parseInt(host.substring(pidx + 1));
- }
- host = host.substring(0, pidx);
+ if (!connectString.startsWith("[")) {//IPv4
--- End diff --
In https://github.com/apache/zookeeper/pull/548, it added
ConfigUtils.getHostAndPort, which can split host port in IPV4 or IPV6 format,
maybe we should reuse that code here.
---
