[
https://issues.apache.org/jira/browse/ZOOKEEPER-3110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570979#comment-16570979
]
Hadoop QA commented on ZOOKEEPER-3110:
--------------------------------------
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that
doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2030//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2030//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2030//console
This message is automatically generated.
> Improve the closeSession throughput in PrepRequestProcessor
> -----------------------------------------------------------
>
> Key: ZOOKEEPER-3110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3110
> Project: ZooKeeper
> Issue Type: Improvement
> Components: quorum
> Reporter: Fangmin Lv
> Assignee: Fangmin Lv
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> On leader every expired global session will add 3 lines of logs, which is
> pretty heavy and if the log file is more than a few GB, the log for the
> closeSession in PrepRequestProcessor will slow down the whole ensemble's
> throughput.
> From some use case, we found the prep request processor will be a bottleneck
> when there are constantly high number of expired session or closing session
> explicitly.
> This JIra is going to remove one of the useless log when prepare close
> session txns, which should give us higher throughput during processing large
> number of expire sessions.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
