[
https://issues.apache.org/jira/browse/ZOOKEEPER-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572791#comment-16572791
]
Hudson commented on ZOOKEEPER-2926:
-----------------------------------
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #143 (See
[https://builds.apache.org/job/ZooKeeper-trunk/143/])
ZOOKEEPER-2926: Fix potential data consistency issue due to the session (hanm:
rev cd209456b67cde5aba771b1a240ebe5607398459)
* (edit) src/java/test/org/apache/zookeeper/test/ClientBase.java
* (edit) src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
* (edit) src/java/test/org/apache/zookeeper/server/MockServerCnxn.java
* (edit) src/java/main/org/apache/zookeeper/server/SessionTracker.java
* (edit)
src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java
* (edit) src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java
* (add)
src/java/test/org/apache/zookeeper/server/quorum/SessionUpgradeQuorumTest.java
* (edit) src/java/test/org/apache/zookeeper/test/QuorumBase.java
* (edit) src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
* (edit) src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java
* (edit) src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
* (edit) src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java
* (edit)
src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java
* (edit) src/java/main/org/apache/zookeeper/server/ServerCnxn.java
* (edit)
src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java
* (edit)
src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java
> Data inconsistency issue due to the flaw in the session management
> ------------------------------------------------------------------
>
> Key: ZOOKEEPER-2926
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2926
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.5.3, 3.6.0
> Reporter: Fangmin Lv
> Assignee: Fangmin Lv
> Priority: Critical
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> The local session upgrading feature will upgrade the session locally before
> receving a quorum commit of creating global session. It's possible that the
> server shutdown before the creating session request being sent to leader, if
> we retained the ZKDatabase or there is Snapshot happened just before
> shutdown, then only this server will have the global session.
> If that server didn't become leader, then it will have more global sessions
> than others, and those global sessions won't expire as the leader doesn't
> know it's existence. If the server became leader, it will accept the client
> renew session request and the client is allowed to create ephemeral nodes,
> which means other servers only have ephemeral nodes but not that global
> session. If there is follower going to have SNAP sync with it, then it will
> also have the global session. If the server without that global session
> becomes new leader, it will check and delete those dangling ephemeral node
> before serving traffic. These could introduce the issues that the ephemeral
> node being exist on some servers but not others.
> There is dangling global session issue even without local session feature,
> because on leader it will update the ZKDatabase when processing
> ConnectionRequest and in the PrepRequestProcessor before it's quorum
> committed, which also has this risk.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
