[ https://issues.apache.org/jira/browse/ZOOKEEPER-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603325#comment-16603325 ]
Hadoop QA commented on ZOOKEEPER-3131: -------------------------------------- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2117//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2117//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2117//console This message is automatically generated. > org.apache.zookeeper.server.WatchManager resource leak > ------------------------------------------------------ > > Key: ZOOKEEPER-3131 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3131 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.5.3, 3.5.4, 3.6.0 > Environment: -Xmx512m > Reporter: ChaoWang > Priority: Major > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > In some cases, the variable _watch2Paths_ in _Class WatchManager_ does not > remove the entry, even if the associated value "HashSet" is empty already. > The type of key in Map _watch2Paths_ is Watcher, instance of > _NettyServerCnxn._ If it is not removed when the associated set of paths is > empty, it will cause the memory increases little by little, and > OutOfMemoryError triggered finally. > > {color:#FF0000}*Possible Solution:*{color} > In the following function, the logic should be added to remove the entry. > org.apache.zookeeper.server.WatchManager#removeWatcher(java.lang.String, > org.apache.zookeeper.Watcher) > if (paths.isEmpty()) > { watch2Paths.remove(watcher); } > For the following function as well: > org.apache.zookeeper.server.WatchManager#triggerWatch(java.lang.String, > org.apache.zookeeper.Watcher.Event.EventType, > java.util.Set<org.apache.zookeeper.Watcher>) > > Please confirm this issue? -- This message was sent by Atlassian JIRA (v7.6.3#76005)