Fine. I'm happy to ignore 1549, 2846 and 2930. Still we have the list of:
- ZOOKEEPER-236 (SSL/TLS support for Atomic Broadcast protocol) - ZOOKEEPER-1818 (Fix don't care for trunk) - ZOOKEEPER-2418 (txnlog diff sync can skip sending some transactions to followers) - ZOOKEEPER-2778 (Potential server deadlock between follower sync with leader and follower receiving external connection requests.) SSL (ZK-236) is a feature which essential for the 3.5 release, hence I wouldn't leave it out or postpone it for the next stable release. PR has been out for a long time, get on reviewing please. The rest are also long outstanding issues which have been found in the 3.5 branch. ZK-1818 is something which was found in 3.4 and fixed in 3.4, but never has been fixed in 3.5. Quite a serious issue if still present. I think we should at least run some manual testing and see if we could repro any of these issues before going ahead with a stable release. Regards, Andor On Fri, Sep 7, 2018 at 3:24 AM, Michael Han <h...@apache.org> wrote: > I haven't went through the entire list, but looks like lots of the JIRA > issues listed in this thread, such as ZOOKEEPER-1549, 2846, also affects > 3.4 releases. Should we scope these issues out? > > I think historically the single outstanding blocking issue for a stable 3.5 > release is the reconfig feature and security concerns around it (somehow > addressed in ZOOKEEPER-2014), and the alpha and beta releases were created > to stabilize that feature. > > http://zookeeper-user.578899.n2.nabble.com/Zookeeper-with- > SSL-release-date-tt7581744.html > > So it looks like we are in good shape to release. Something might worth > doing to claim the quality of 3.5 is on par with 3.4 > > * Run Jepsen on 3.5 - 3.4 passed the test for the record > https://aphyr.com/posts/291-jepsen-zookeeper > * Fix all flaky tests on 3.5 - 3.4 has little or no flaky tests at all. > > > On Tue, Sep 4, 2018 at 1:48 AM, Andor Molnar <an...@cloudera.com.invalid> > wrote: > > > Thanks Maoling! That would be huge help, I appreciate it. > > > > Andor > > >