Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/601#discussion_r216654230
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -1486,6 +1490,377 @@ public TestQPMain getTestQPMain() {
}
}
+ /**
+ * Verify boot works configuring a MetricsProvider
+ */
+ @Test
+ public void testMetricsProviderLifecycle() throws Exception {
--- End diff --
`QuorumPeerMainTest` takes about 193 seconds to run on current master
branch on my machine. These new tests add another ~30 seconds to it. I'm also
seeing these test cases more or less covered by new ZooKeeperServer tests. What
do you think of skip adding new tests here?
---
