Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/625
I don't have a local environment to test C client at the moment, but from
Jenkins, this pull request does not build:
[exec] [exec]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:307:9:
error: passing argument 1 of 'SSL_write' from incompatible pointer type
[-Werror]
[exec] [exec] return (ssize_t)SSL_write(fd->ssl_sock,
buf, (int)len);
[exec] [exec] ^
[exec] [exec] In file included from
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:45:0:
[exec] [exec] /usr/include/openssl/ssl.h:1860:6: note: expected
'struct SSL *' but argument is of type 'int *'
[exec] [exec] int SSL_write(SSL *ssl,const void *buf,int num);
[exec] [exec] ^
[exec] [exec]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:
In function 'zookeeper_recv':
[exec] [exec]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:315:9:
error: passing argument 1 of 'SSL_read' from incompatible pointer type
[-Werror]
[exec] [exec] return (ssize_t)SSL_read(fd->ssl_sock,
buf, (int)len);
[exec] [exec] ^
[exec] [exec] In file included from
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:45:0:
[exec] [exec] /usr/include/openssl/ssl.h:1858:6: note: expected
'struct SSL *' but argument is of type 'int *'
[exec] [exec] int SSL_read(SSL *ssl,void *buf,int num);
[exec] [exec] ^
[exec] [exec]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:
In function 'close_zsock':
[exec] [exec]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:550:9:
error: passing argument 1 of 'SSL_free' from incompatible pointer type
[-Werror]
[exec] [exec] SSL_free(fd->ssl_sock);
[exec] [exec] ^
[exec] [exec] In file included from
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:45:0:
[exec] [exec] /usr/include/openssl/ssl.h:1855:6: note: expected
'struct SSL *' but argument is of type 'int *'
[exec] [exec] void SSL_free(SSL *ssl);
[exec] [exec] ^
[exec] [exec]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:552:9:
error: passing argument 1 of 'SSL_CTX_free' from incompatible pointer type
[-Werror]
[exec] [exec] SSL_CTX_free(fd->ssl_ctx);
[exec] [exec] ^
[exec] [exec] In file included from
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:45:0:
[exec] [exec] /usr/include/openssl/ssl.h:1681:6: note: expected
'struct SSL_CTX *' but argument is of type 'int *'
[exec] [exec] void SSL_CTX_free(SSL_CTX *);
[exec] [exec] ^
[exec] [exec]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:
In function 'zookeeper_ssl_init':
[exec] [exec]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:1285:5:
error: initialization discards 'const' qualifier from pointer target type
[-Werror]
[exec] [exec] zcert_t *c = &((zcert_t) {.ca = ca, .cert =
cert, .key = key, .passwd = passwd});
[exec] [exec] ^
[exec] [exec]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:1285:5:
error: initialization discards 'const' qualifier from pointer target type
[-Werror]
[exec] [exec]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:1285:5:
error: initialization discards 'const' qualifier from pointer target type
[-Werror]
[exec] [exec]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:1285:5:
error: initialization discards 'const' qualifier from pointer target type
[-Werror]
[exec] [exec]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:
In function 'zookeeper_ssl_init2':
[exec] [exec]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:1293:5:
error: passing argument 8 of 'zookeeper_init_internal' from incompatible
pointer type [-Werror]
[exec] [exec] return zookeeper_init_internal(host, watcher,
recv_timeout, clientid, context, flags, log_callback, cert);
[exec] [exec] ^
[exec] [exec]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:1146:19:
note: expected 'struct zcert_t *' but argument is of type 'const char *'
[exec] [exec] static zhandle_t *zookeeper_init_internal(const
char *host, watcher_fn watcher,
[exec] [exec] ^
[exec] [exec]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:
In function 'zookeeper_connect':
[exec] [exec]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:2299:9:
error: ISO C90 forbids mixed declarations and code
[-Werror=declaration-after-statement]
[exec] [exec] int err = SSL_ERROR_NONE;
[exec] [exec] ^
[exec] [exec]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:2304:26:
error: assignment from incompatible pointer type [-Werror]
[exec] [exec] zh->fd->ssl_sock = ssl;
[exec] [exec] ^
[exec] [exec]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/c/src/zookeeper.c:2305:25:
error: assignment from incompatible pointer type [-Werror]
[exec] [exec] zh->fd->ssl_ctx = ctx;
[exec] [exec] ^
[exec] [exec] cc1: all warnings being treated as errors
[exec] [exec] make: *** [zookeeper.lo] Error 1
---
