Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/590#discussion_r219643998
  
    --- Diff: src/java/main/org/apache/zookeeper/server/watch/WatchManager.java 
---
    @@ -83,18 +97,21 @@ synchronized void removeWatcher(Watcher watcher) {
                 Set<Watcher> list = watchTable.get(p);
                 if (list != null) {
                     list.remove(watcher);
    -                if (list.size() == 0) {
    +                if (list.isEmpty()) {
                         watchTable.remove(p);
                     }
                 }
             }
         }
     
    -    Set<Watcher> triggerWatch(String path, EventType type) {
    +    @Override
    +    public WatcherOrBitSet triggerWatch(String path, EventType type) {
             return triggerWatch(path, type, null);
         }
     
    -    Set<Watcher> triggerWatch(String path, EventType type, Set<Watcher> 
supress) {
    +    @Override
    +    public WatcherOrBitSet triggerWatch(
    +            String path, EventType type, WatcherOrBitSet supress) {
    --- End diff --
    
    `suppress ` instead of `supress`


---

Reply via email to