Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/628#discussion_r221393478
  
    --- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml 
---
    @@ -764,6 +764,16 @@ server.3=zoo3:2888:3888</programlisting>
                 </listitem>
               </varlistentry>
     
    +          <varlistentry>
    +            <term>observerMasterPort</term>
    +
    +            <listitem>
    +              <para>the port to listen for observer connections; that is, 
the
    +                port that observers attempt to connect to.</para>
    +              <para>if the property is set then the feature is enabled 
locally.</para>
    --- End diff --
    
    I think it's worth to mention what "the feature" is here. 
    
    We could add some descriptions to [zookeeperObservers 
documentation](https://zookeeper.apache.org/doc/r3.5.4-beta/zookeeperObservers.html).
 The descriptions in the 
[JIRA](https://jira.apache.org/jira/browse/ZOOKEEPER-3140) is pretty good 
candidate to put in the doc.


---

Reply via email to