Github user eolivelli commented on the pull request:
https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31151424
In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java:
In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java
on line 544:
The best is to have complete control over this.
We should run disableCertFileReloading in an explicit "shutdown"/"close"
method.
We cannot count on Java finalization, I suggest to drop this
"finalizerGuardian", we have full control on both server and client
stopping/close procedures so I think we can safely rely on:
- server shutdown (the process will die....)
- client calls ZooKeeper#close (it it does not so the application is
already buggy)
---
