[GitHub] zookeeper pull request #684: ZOOKEEPER-3180: Add response cache to improve t...

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/684#discussion_r230973727
  
    --- Diff: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java 
---
    @@ -235,10 +237,12 @@ void handleWrite(SelectionKey k) throws IOException, 
CloseRequestException {
                     if (bb == ServerCnxnFactory.closeConn) {
                         throw new CloseRequestException("close requested");
                     }
    +                if (bb == packetSentinel) {
    --- End diff --
    
    Seems like you're fixing a bug by introducing `packetSentinel`. Is that 
correct?


---