Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/702#discussion_r234101680
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/auth/QuorumAuth.java
---
@@ -38,10 +38,10 @@
public static final String
QUORUM_KERBEROS_SERVICE_PRINCIPAL_DEFAULT_VALUE = "zkquorum/localhost";
public static final String QUORUM_LEARNER_SASL_LOGIN_CONTEXT =
"quorum.auth.learner.saslLoginContext";
- public static final String
QUORUM_LEARNER_SASL_LOGIN_CONTEXT_DFAULT_VALUE = "QuorumLearner";
+ public static final String
QUORUM_LEARNER_SASL_LOGIN_CONTEXT_DEFAULT_VALUE = "QuorumLearner";
--- End diff --
IMHO it is better not to change is constants, they are part of a public API
---