Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/700
  
    @eolivelli @hanm Now, an entirely different approach. Solving 2 issues at 
the same time:
    1) Close selector in shutdown() when Accept and Select thread haven't been 
started yet. This will keep the original behaviour of eagerly register the 
selector in the constructor and addresses your concerns.
    2) Turned out that we have a similar issue in reconfig: There was an issue 
with `ReconfigTest.testPortChangeToBlockedPort`: it expects the original port 
to be released even if the new port cannot be bound. Sounds like a reasonable 
expectation and the exception handler in the `reconfigure()` method confirms 
this. Hence I fixed the code, not the test.


---

Reply via email to