Github user eolivelli commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/711#discussion_r235383411
  
    --- Diff: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java 
---
    @@ -864,6 +860,17 @@ public static int getSnapCount() {
             }
         }
     
    +    public int getGlobalOutstandingLimit() {
    +        String sc = System.getProperty(GLOBAL_OUTSTANDING_LIMIT);
    --- End diff --
    
    are we reading the system property and parsing the value at every call of 
shouldThrottle ?
    can't we cache the value ?


---

Reply via email to