Github user mkedwards commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/721#discussion_r236097804
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/test/DisconnectedWatcherTest.java
---
@@ -221,6 +228,7 @@ public void testManyChildWatchersAutoReset() throws
Exception {
watcher.waitForDisconnected(30000);
startServer();
watcher.waitForConnected(30000);
+ watcher1.waitForConnected(30000);
--- End diff --
That example is due to an unrelated class of failure, in which the
Zookeeper server is permanently unreachable (notice that the entire test timed
out); I think many failure cases of that kind are the product of failure to
bind() the dynamically-assigned port to the server socket (probably due to
collisions with other tests running concurrently on the same build host). I've
updated the description of this PR to explain what kind of failure it's
intended to fix.
---
