Spotbugs: https://github.com/apache/zookeeper/pull/742
Enrico Il giorno gio 20 dic 2018 alle ore 15:09 Norbert Kalmar <nkal...@cloudera.com.invalid> ha scritto: > > Here's the PR, open for feedback! :) > https://github.com/apache/zookeeper/pull/741 > > Regards, > Norbert > > On Thu, Dec 20, 2018 at 2:47 PM Enrico Olivelli <eolive...@gmail.com> wrote: > > > New JIRA ticket > > https://issues.apache.org/jira/browse/ZOOKEEPER-3226 > > > > I have assigned it to you Norbert as you are working on it. > > I can pick it up as well > > > > Enrico > > > > > > Il giorno gio 20 dic 2018 alle ore 14:44 Norbert Kalmar > > <nkal...@cloudera.com.invalid> ha scritto: > > > > > > Great question Enrico, I also thought about it. > > > > > > There is actually already a "Linux profile", so that tests only run when > > it > > > is on Linux system. I wanted to fine grain thath, as ant checks if the > > > required make commands are available. But for a "quick-fix" I made it so > > > that it only runs on Linux. Then I forgot about it... it should > > definitely > > > be changed. And ant already does something like this (if you don't have > > the > > > required infrastructure, c build will not run.) > > > > > > But just creating a profile for building and testing C client is a good > > > idea, so +1 from my side. > > > > > > > > > > Regards, > > > Norbert > > > > > > On Thu, Dec 20, 2018 at 2:29 PM Enrico Olivelli <eolive...@gmail.com> > > wrote: > > > > > > > Hi, > > > > can't we create a "profile" in order to build and test the C Client ? > > > > > > > > I think that very few developers are working on it, it is only a > > > > burden for Java developers. > > > > > > > > CI will build and run tests > > > > > > > > Thoughts ? > > > > > > > > Enrico > > > > > >
