Jiafu Jiang created ZOOKEEPER-3231:
--------------------------------------
Summary: Purge task may lost data when we have many invalid
snapshot files.
Key: ZOOKEEPER-3231
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3231
Project: ZooKeeper
Issue Type: Bug
Components: server
Affects Versions: 3.4.13, 3.5.4
Reporter: Jiafu Jiang
I read the ZooKeeper source code, and I find the purge task use
FileTxnSnapLog#findNRecentSnapshots to find snapshots, but the method does not
check whether the snapshots are valid.
Consider a worse case, a ZooKeeper server may have many invalid snapshots, and
when a purge task begins, is will use the zxid in the last snapshot file name
to purge old snapshots or transaction logs, then we may lost data.
I think we should use FileSnap#findNValidSnapshots(int) instead of
FileSnap#findNRecentSnapshots in FileTxnSnapLog#findNRecentSnapshots. I am not
sure.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
