awesome !!! ----- 原始邮件 ----- 发件人：Norbert Kalmar <[email protected]> 收件人：[email protected] 主题：Re: Maven migration and C client 日期：2018年12月30日 18点06分
Hi Enrico, 2 PRs waiting for commit, C build with profile: https://github.com/apache/zookeeper/pull/741 And rest of the pom files for building recipes and contrib: https://github.com/apache/zookeeper/pull/745 Other then these, the code coverage is left to do, some modification to create the reports for both C and Java. This should be fairly easy to finish. Only thing left is doing the assembly ( https://issues.apache.org/jira/browse/ZOOKEEPER-3028), but I think it's best to wait for current patches to be committed. I think (hope) it can be finished in the first half of January (current patches to be committed, and the few fix and assembly left to be submitted and committed, then test if a release can be made with maven - Andor said he can test it, as it requires a committer). Regards, Norbert On Fri, Dec 28, 2018 at 8:33 PM Enrico Olivelli <[email protected]> wrote: > Hi Norbert, > How is maven migration going? > Is there any blocker issue? > > Enrico > > Il gio 20 dic 2018, 17:19 Enrico Olivelli <[email protected]> ha > scritto: > > > Spotbugs: > > https://github.com/apache/zookeeper/pull/742 > > > > Enrico > > > > Il giorno gio 20 dic 2018 alle ore 15:09 Norbert Kalmar > > <[email protected]> ha scritto: > > > > > > Here's the PR, open for feedback! :) > > > https://github.com/apache/zookeeper/pull/741 > > > > > > Regards, > > > Norbert > > > > > > On Thu, Dec 20, 2018 at 2:47 PM Enrico Olivelli <[email protected]> > > wrote: > > > > > > > New JIRA ticket > > > > https://issues.apache.org/jira/browse/ZOOKEEPER-3226 > > > > > > > > I have assigned it to you Norbert as you are working on it. > > > > I can pick it up as well > > > > > > > > Enrico > > > > > > > > > > > > Il giorno gio 20 dic 2018 alle ore 14:44 Norbert Kalmar > > > > <[email protected]> ha scritto: > > > > > > > > > > Great question Enrico, I also thought about it. > > > > > > > > > > There is actually already a "Linux profile", so that tests only run > > when > > > > it > > > > > is on Linux system. I wanted to fine grain thath, as ant checks if > > the > > > > > required make commands are available. But for a "quick-fix" I made > > it so > > > > > that it only runs on Linux. Then I forgot about it... it should > > > > definitely > > > > > be changed. And ant already does something like this (if you don't > > have > > > > the > > > > > required infrastructure, c build will not run.) > > > > > > > > > > But just creating a profile for building and testing C client is a > > good > > > > > idea, so +1 from my side. > > > > > > > > > > > > > > > > > > Regards, > > > > > Norbert > > > > > > > > > > On Thu, Dec 20, 2018 at 2:29 PM Enrico Olivelli < > [email protected] > > > > > > > wrote: > > > > > > > > > > > Hi, > > > > > > can't we create a "profile" in order to build and test the C > > Client ? > > > > > > > > > > > > I think that very few developers are working on it, it is only a > > > > > > burden for Java developers. > > > > > > > > > > > > CI will build and run tests > > > > > > > > > > > > Thoughts ? > > > > > > > > > > > > Enrico > > > > > > > > > > > > > -- > > > -- Enrico Olivelli >
