anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs URL: https://github.com/apache/zookeeper/pull/742#discussion_r244962944
########## File path: excludeFindBugsFilter.xml ########## @@ -0,0 +1,14 @@ +<?xml version="1.0" encoding="UTF-8"?> + +<FindBugsFilter> Review comment: Naming is a little bit confusing I think. Given that this is a config file of `spotBugs`, shouldn't we call it `spotBugsFilter.xml` instead? Though the XML tag name has remained "FindBugs", so I'm not sure. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
