[
https://issues.apache.org/jira/browse/ZOOKEEPER-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
maoling updated ZOOKEEPER-3191:
-------------------------------
Description:
Working on some feature for Zookeeper I've found strange and redundant code in
several places, like:
* 1. [if true set
true|https://github.com/apache/zookeeper/blob/a859410aea35dfef5fa54c99fb8a5bfc81f1a46b/src/java/main/org/apache/zookeeper/server/quorum/Leader.java#L388-L398]
* 2 .[redundant
code|https://github.com/apache/zookeeper/blob/a859410aea35dfef5fa54c99fb8a5bfc81f1a46b/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java#L124-L126]
* 3. [redundant
code|https://github.com/apache/zookeeper/blob/a859410aea35dfef5fa54c99fb8a5bfc81f1a46b/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L462]
It makes difficult working with code. So maybe it should be cleaned up?
was:
Working on some feature for Zookeeper I've found strange and redundant code in
several places, like:
* [if true set
true|https://github.com/apache/zookeeper/blob/a859410aea35dfef5fa54c99fb8a5bfc81f1a46b/src/java/main/org/apache/zookeeper/server/quorum/Leader.java#L388-L398]
* [redundant
code|https://github.com/apache/zookeeper/blob/a859410aea35dfef5fa54c99fb8a5bfc81f1a46b/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java#L124-L126]
* [redundant
code|https://github.com/apache/zookeeper/blob/a859410aea35dfef5fa54c99fb8a5bfc81f1a46b/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L462]
It makes difficult working with code. So maybe it should be cleaned up?
> Code clean up
> -------------
>
> Key: ZOOKEEPER-3191
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3191
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Artem Chernatsky
> Priority: Minor
>
> Working on some feature for Zookeeper I've found strange and redundant code
> in several places, like:
> * 1. [if true set
> true|https://github.com/apache/zookeeper/blob/a859410aea35dfef5fa54c99fb8a5bfc81f1a46b/src/java/main/org/apache/zookeeper/server/quorum/Leader.java#L388-L398]
> * 2 .[redundant
> code|https://github.com/apache/zookeeper/blob/a859410aea35dfef5fa54c99fb8a5bfc81f1a46b/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java#L124-L126]
> * 3. [redundant
> code|https://github.com/apache/zookeeper/blob/a859410aea35dfef5fa54c99fb8a5bfc81f1a46b/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L462]
> It makes difficult working with code. So maybe it should be cleaned up?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
