nkalmar commented on a change in pull request #764: ZOOKEEPER-3223: Configure Spotbugs - on branch 3.4 URL: https://github.com/apache/zookeeper/pull/764#discussion_r247343700
########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/CommitProcessor.java ########## @@ -18,8 +18,12 @@ package org.apache.zookeeper.server.quorum; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import java.util.ArrayList; import java.util.LinkedList; +import java.util.concurrent.atomic.AtomicInteger; +import java.util.concurrent.atomic.AtomicReference; +import java.util.concurrent.LinkedBlockingQueue; Review comment: Why import these 4? I don't see this used in the class, but I might be missing something. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
