eolivelli commented on a change in pull request #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#discussion_r248048607
########## File path: src/assembly/jar.xml ########## @@ -0,0 +1,65 @@ +<assembly xmlns="http://maven.apache.org/ASSEMBLY/2.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.0.0 http://maven.apache.org/xsd/assembly-2.0.0.xsd";> + + <id>jar</id> Review comment: Why do we need this file? We are splitting the project in sub modules, it is better to have one jar per module. I guess you are trying to reproduce the ant based build but it is not necessary to me. Maven has already its clear way of distributing the artifacts. Or maybe I am missing some part of the story ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
