anmolnar commented on a change in pull request #784: ZOOKEEPER-974: Allow a
configurable ZooKeeper server socket listen ba…
URL: https://github.com/apache/zookeeper/pull/784#discussion_r250563613
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
##########
@@ -451,6 +458,9 @@ public void shutdown() {
@Override
public void start() {
+ if (listenBacklog > 0) {
Review comment:
It doesn't make any difference, but it would nice for this condition to be
consistent with the NIO implementation.
e.g. `listenBacklog != -1` or something similar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
