joshelser commented on issue #784: ZOOKEEPER-974: Allow a configurable ZooKeeper server socket listen ba… URL: https://github.com/apache/zookeeper/pull/784#issuecomment-458234562 Thanks for the review, Andor and maoling! > Would you please consider adding some unit tests covering both connection factories? (nio & netty) Yeah, I can try to do this. I had started trying to look into the NIO/Netty APIs to make sure I could pull the socket listen config back out of the server, and got stuck. I'd happily welcome any suggestions on how to write a not-contrived test :) > if clientPortBacklog = -1,it will use the default value:50 (too small if server has many incoming requests). Yup! That's how we stumbled onto this issue in the first place. > need a doc.it's better to write something like this: Agree. Meant to include doc updates -- forgot :D
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
