FYI This is the first PR validate with Maven and Ant https://github.com/apache/zookeeper/pull/794
This is the job https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build-maven/ Currently it is activated only by commenting a PR with 'test maven build' from an "Apache Committer". I can activate it by default as soon as we want, it is only a matter of changing a couple of flags on the job configuration The precommit job is really simpler than the ant based one, it only does these checks: - 'verify' -> build and run java tests - spotbugs I will wait ack from any committer before updating the config (anyone with permission on CI can do it, of course!!!) Enrico Il giorno gio 31 gen 2019 alle ore 19:00 Norbert Kalmar <[email protected]> ha scritto: > > Awesome, thanks Enrico! > > On Thu, Jan 31, 2019 at 10:57 AM Andor Molnar <[email protected]> > wrote: > > > Turned out that it's enough to merge it to master branch, the rest is fine. > > Enrico is now ready to add the maven build to the pull request checks which > > will be a huge improvement. > > > > Andor > > > > > > > > On Thu, Jan 31, 2019 at 11:07 AM Enrico Olivelli <[email protected]> > > wrote: > > > > > Hi ZooKeepers ! > > > Maven build keeps breaking. > > > > > > This is the fix > > > https://github.com/apache/zookeeper/pull/793 > > > > > > Once this fix lands to every branch I would like to setup a CI job to > > > run Maven build against Pull Request (additionally to the ant based CI > > > job) > > > > > > Note: > > > Current ant based CI job is very complex and it makes a lots of > > > checks, my first version of the job will only compile, test and > > > package > > > > > > Regards > > > > > > Enrico > > > > >
