nkalmar commented on a change in pull request #818: ZOOKEEPER-3275: Fix release
targets: package, tar, mvn-deploy (3.4)
URL: https://github.com/apache/zookeeper/pull/818#discussion_r256295117
##########
File path: zookeeper-contrib/zookeeper-contrib-zooinspector/build.xml
##########
@@ -125,22 +125,18 @@
<target name="package" depends="jar, zookeeperbuildcontrib.package"
unless="skip.contrib">
- <copy file="${basedir}/build.xml"
todir="${dist.dir}/contrib/${name}" />
+ <copy file="${basedir}/build.xml"
todir="${dist.dir}/zookeeper-contrib/zookeeper-contrib-${name}" />
- <mkdir dir="${dist.dir}/contrib/${name}/src" />
- <copy todir="${dist.dir}/contrib/${name}/src">
+ <mkdir
dir="${dist.dir}/zookeeper-contrib/zookeeper-contrib-${name}/src" />
+ <copy
todir="${dist.dir}/zookeeper-contrib/zookeeper-contrib-${name}/src">
<fileset dir="${basedir}/src" />
</copy>
- <mkdir dir="${dist.dir}/contrib/${name}/licences" />
- <copy todir="${dist.dir}/contrib/${name}/licences">
+ <mkdir
dir="${dist.dir}/zookeeper-contrib/zookeeper-contrib-${name}/licences" />
+ <copy
todir="${dist.dir}/zookeeper-contrib/zookeeper-contrib-${name}/licences">
<fileset dir="${basedir}/licences" />
</copy>
- <mkdir dir="${dist.dir}/contrib/${name}/icons" />
- <copy todir="${dist.dir}/contrib/${name}/icons">
- <fileset dir="${basedir}/src/main/resources/icons" />
- </copy>
- <mkdir dir="${dist.dir}/contrib/${name}/config" />
- <copy todir="${dist.dir}/contrib/${name}/config">
+ <mkdir
dir="${dist.dir}/zookeeper-contrib/zookeeper-contrib-${name}/config" />
+ <copy
todir="${dist.dir}/zookeeper-contrib/zookeeper-contrib-${name}/config">
<fileset dir="${basedir}/src/main/resources">
<include name="defaultConnectionSettings.cfg" />
<include name="defaultNodeViewers.cfg" />
Review comment:
Please modify the 2 copy tasks at the bottom of this file:
<copy todir="${dist.dir}/contrib/${name}/lib">
Should be:
${dist.dir}/zookeeper-contrib/zookeeper-contrib-${name}/lib
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
