phunt commented on issue #835: Fix for lincense files and contrib folder during release URL: https://github.com/apache/zookeeper/pull/835#issuecomment-467285727 I don't think we should commit this. I may be confused - only branch 3.4 is jline 0.9 but that already has a license file in the source repo: [phunt:~/dev/zookeeper-br34] branch-3.4 ± ff jline ./zookeeper-server/src/main/resources/jline-0.9.94.LICENSE.txt branch 3.5/master are using 2.11 and the file is there: [phunt:~/dev/zookeeper-br35] branch-3.5 ± ff jline ./zookeeper-server/src/main/resources/lib/jline-2.11.LICENSE.txt so while excluding the jar aspect of the patch seems fine, adding another license doesn't seem necessary. LIkely an issue the the library packaging?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
