enixon commented on issue #831: ZOOKEEPER-3286: xid wrap-around causes connection loss/segfault when hitting predefined XIDs URL: https://github.com/apache/zookeeper/pull/831#issuecomment-470214811 The code looks good to me. As for the unit test, making the counter global strikes me as overkill too but I'll let someone who represents the project make the actual decision.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
