+1 (non binding) checked signatures/checksums run Java tests with ANT on java 11 (adoptopenjdk 11.0.2) run smoke tests (3 nodes cluster/zkCli.sh, with java 8/11
Enrico Il giorno mar 12 mar 2019 alle ore 10:48 Norbert Kalmar <[email protected]> ha scritto: > > I'm fine with this RC, this jar was shipped in prior releases as well. > (Might I even say someone may be using this jar from the tarball? :) I > know, hardly the case...) > Anyway, we can remove the jar, and it will be removed from tarball with the > next release if we want. Or wait for a new RC if others think we should. > > Personally, I keep my +1 (non-binding) > > Regards, > Norbert > > On Mon, Mar 11, 2019 at 8:16 PM Andor Molnar <[email protected]> > wrote: > > > Hi Enrico, > > > > Thanks for pointing that out. > > I talked to Norbert and Patrick about that and mentioned we were shipping > > that jar in previous releases too, so it should be fine in licensing wise. > > > > I'm happy to create another RC if other people think we should take that > > one out too, but it seems to me we're still fine. > > > > Regards, > > Andor > > > > > > > > > > On Sat, Mar 9, 2019 at 12:28 AM Enrico Olivelli <[email protected]> > > wrote: > > > > > Before sending my vote I found a audience-annotations-0.5.0.jar > > > > > > Is it needed at runtime? > > > I did not yet have time to check > > > > > > Enrico > > > > > > Il gio 7 mar 2019, 15:23 Norbert Kalmar <[email protected]> > > ha > > > scritto: > > > > > > > +1 (non-binding) > > > > > > > > checked signatures and checksums > > > > built from source (oracle jdk8 and openjdk 11.0.2) > > > > run java tests (openjdk 11.0.2) > > > > run native tests > > > > checked jar files and license files compared to 3.4.13 (didn't see any > > > > extra jars this time) > > > > run zk in a 3-node ensemble (openjdk 11.0.2) > > > > run cli and tested basic commands > > > > > > > > Regards, > > > > Norbert > > > > > > > > On Wed, Mar 6, 2019 at 7:56 PM Andor Molnar <[email protected]> wrote: > > > > > > > > > This is a bugfix release candidate for 3.4.14. It fixes 8 issues, > > > mostly > > > > > build / unit tests issues, > > > > > dependency updates flagged by OWASP, NPE and a name resolution > > problem. > > > > > Among these it also supports > > > > > experimental Maven build and Markdown based documentation generation. > > > > > > > > > > The full release notes is available at: > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12343587 > > > > > > > > > > *** Please download, test and vote by March 10th 2019, 23:59 UTC+0. > > *** > > > > > > > > > > Source files: > > > > > > > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.4.14-rc5/ > > > > > > > > > > Maven staging repo: > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.4.14/ > > > > > > > > > > The release candidate tag in git to be voted upon: release-3.4.14-rc5 > > > > > > > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > > > > > http://www.apache.org/dist/zookeeper/KEYS > > > > > > > > > > Should we release this candidate? > > > > > > > > > > Regards, > > > > > Andor > > > > > > > > > > > > > > > > > > > > > > > >
