anmolnar commented on issue #838: ZOOKEEPER-2168 Add C APIs for new createContainer Methods URL: https://github.com/apache/zookeeper/pull/838#issuecomment-473108515 @meszibalu I tend to accept this patch with that unit test. Seems like there's literally nothing more we can do about it. I was thinking of creating child nodes, deleting them and waiting for the container to be automatically deleted, but first, it could easily become flaky and second, you have to wait for 1 minute. The timeout is configurable, but the way we start those tests cannot let us change the config easily.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
