lvfangmin commented on a change in pull request #849: ZOOKEEPER-3305: Add
Quorum Packet metrics
URL: https://github.com/apache/zookeeper/pull/849#discussion_r265853817
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
##########
@@ -649,6 +683,14 @@ public void run() {
}
}
+ /**
+ * Tests need not send marker packets as they are only needed to
+ * log quorum packet delays
+ */
+ protected boolean shouldSendMarkerPacketForLogging() {
Review comment:
Can you remind me what's the purpose of having this function, why we need to
overwrite it in test? Will it break the existing test without set it to false?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
