eolivelli commented on a change in pull request #853: ZOOKEEPER-3316: Remove
unused code in SyncRequestProcessor
URL: https://github.com/apache/zookeeper/pull/853#discussion_r266155574
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/SyncRequestProcessor.java
##########
@@ -117,48 +117,35 @@ public void run() {
if (si == requestOfDeath) {
break;
}
- if (si != null) {
- // track the number of records written to the log
- if (zks.getZKDatabase().append(si)) {
- logCount++;
- if (logCount > (snapCount / 2 + randRoll)) {
- randRoll = r.nextInt(snapCount/2);
- // roll the log
- zks.getZKDatabase().rollLog();
- // take a snapshot
- if (snapInProcess != null &&
snapInProcess.isAlive()) {
- LOG.warn("Too busy to snap, skipping");
- } else {
- snapInProcess = new ZooKeeperThread("Snapshot
Thread") {
- public void run() {
- try {
- zks.takeSnapshot();
- } catch(Exception e) {
- LOG.warn("Unexpected
exception", e);
- }
+
+ // track the number of records written to the log
+ if (zks.getZKDatabase().append(si)) {
+ logCount++;
+ if (logCount > (snapCount / 2 + randRoll)) {
+ randRoll = r.nextInt(snapCount/2);
+ // roll the log
+ zks.getZKDatabase().rollLog();
+ // take a snapshot
+ if (snapInProcess != null && snapInProcess.isAlive()) {
+ LOG.warn("Too busy to snap, skipping");
+ } else {
+ snapInProcess = new ZooKeeperThread("Snapshot
Thread") {
+ public void run() {
+ try {
+ zks.takeSnapshot();
+ } catch(Exception e) {
+ LOG.warn("Unexpected exception",
e);
}
- };
- snapInProcess.start();
- }
- logCount = 0;
- }
- } else if (toFlush.isEmpty()) {
- // optimization for read heavy workloads
Review comment:
Seems that the branch described as an "optimization", introduced with
https://issues.apache.org/jira/browse/ZOOKEEPER-568 is not really executed.
This patch is dropping that branch, this is fine, as it is never executed.
I wonder if we could resume somehow the reasoning behind ZOOKEEPER-568, for
the future I mean
cc @breed @phunt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
