anmolnar commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server URL: https://github.com/apache/zookeeper/pull/854#issuecomment-474594384 @eolivelli I got you, I've just found the `enum` more readable (no need for `getMetrics()` call). In my understanding we have another level of abstraction now which cannot be easily achieved by the `enum`. I'll leave this to more experienced Java developers to decide, but it seems that `enum` is not an option anymore. Q: why do you use volatile for `ServerMetrics` reference instead of `AtomicReference`?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
