maoling commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI 
command does not wait for result from server
URL: https://github.com/apache/zookeeper/pull/823#discussion_r267165855
 
 

 ##########
 File path: 
zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java
 ##########
 @@ -55,14 +57,18 @@ public CliCommand parse(String[] cmdArgs) throws 
CliParseException {
     @Override
     public boolean exec() throws CliException {
         String path = args[1];
+        CountDownLatch latch = new CountDownLatch(1);
 
 Review comment:
   @anmolnar  Great work. you are so sweet!  it's very elegant especially when 
we want to transfer the result value.
   Cc:Thanks @eolivelli  for mentioning this good option:`CompletableFuture` 
again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to