[
https://issues.apache.org/jira/browse/ZOOKEEPER-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804164#comment-16804164
]
David Mollitor commented on ZOOKEEPER-3020:
-------------------------------------------
Created a new PR
[https://github.com/apache/zookeeper/pull/876]
> Review of SyncRequestProcessor
> ------------------------------
>
> Key: ZOOKEEPER-3020
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3020
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: David Mollitor
> Priority: Minor
> Labels: pull-request-available
> Attachments: ZOOKEEPER.3020.1.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> # Use {{ArrayDeque}} instead of {{LinkedList}}
> # Use {{ThreadLocalRandom}} instead of {{Random}}
> # Remove the 'running' flag - use the {{Thread#join}} facility to detect if
> the thread has stopped running. Using a flag can cause race condition issues
> and is superfluous.
> # Make static final variable names in all caps
> # General cleanup
> {quote}
> This class is likely to be faster than Stack when used as a stack, and faster
> than LinkedList when used as a queue.
> {quote}
> https://docs.oracle.com/javase/7/docs/api/java/util/ArrayDeque.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
