BELUGABEHR commented on a change in pull request #882: ZOOKEEPER-3342: Use
StandardCharsets
URL: https://github.com/apache/zookeeper/pull/882#discussion_r270523659
##########
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/common/AtomicFileWritingIdiomTest.java
##########
@@ -348,12 +350,12 @@ private String getContent(File file, String encoding)
throws IOException {
}
private String getContent(File file) throws IOException {
- return getContent(file, "ASCII");
+ return getContent(file, StandardCharsets.US_ASCII);
Review comment:
For this test class, it's consistent in that it expects Ascii on line
356/358. Ascii fits perfectly fine into UTF-8 so this test is not invalid and
probably doesn't add any value to change it because the data being used in this
test is not outside the ASCII range.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
