tamaashu edited a comment on issue #882: ZOOKEEPER-3342: Use StandardCharsets URL: https://github.com/apache/zookeeper/pull/882#issuecomment-478464901 What if someone uses ZooKeeper on Windows? Is your change not breaking backward compatibility? "Windows applications use the UTF-16 implementation of Unicode" source: https://docs.microsoft.com/en-us/windows/desktop/intl/character-sets I think we should not change the default within a minor release. If we want to keep backward compatibility, but also would like to make it possible to have a common charset, we should make it configurable and keep the default as it is. In a major release we can change the default to UTF-8.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
