BELUGABEHR commented on a change in pull request #888: ZOOKEEPER-3347: Improve
PathTrie Consistency
URL: https://github.com/apache/zookeeper/pull/888#discussion_r271733653
##########
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/server/DataTreeTest.java
##########
@@ -222,7 +222,7 @@ public void testPathTrieClearOnDeserialize() throws
Exception {
PathTrie pTrie = (PathTrie)pfield.get(dserTree);
//Check that the node path is removed from pTrie
- Assert.assertEquals("/bug is still in pTrie", "",
pTrie.findMaxPrefix("/bug"));
+ Assert.assertEquals("/bug is still in pTrie", "/",
pTrie.findMaxPrefix("/bug"));
Review comment:
The root node is always a prefix. This change puts this method in line with
the rest of the code base which all makes this assumption.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
