anmolnar commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI
command does not wait for result from server
URL: https://github.com/apache/zookeeper/pull/823#discussion_r272072869
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java
##########
@@ -55,18 +61,27 @@ public CliCommand parse(String[] cmdArgs) throws
CliParseException {
@Override
public boolean exec() throws CliException {
String path = args[1];
+ CompletableFuture<Integer> cf = new CompletableFuture<>();
+
try {
zk.sync(path, new AsyncCallback.VoidCallback() {
-
public void processResult(int rc, String path, Object ctx) {
- out.println("Sync returned " + rc);
+ cf.complete(rc);
}
}, null);
+
+ try {
+ int resultCode = cf.get(CONNECTION_TIMEOUT,
TimeUnit.MILLISECONDS);
+ out.println("Sync returned " + resultCode);
+ } catch (TimeoutException ex) {
+ out.println("Sync is timeout within " + CONNECTION_TIMEOUT +
" ms");
+ }
} catch (IllegalArgumentException ex) {
throw new MalformedPathException(ex.getMessage());
+ } catch (InterruptedException | ExecutionException ex) {
Review comment:
About catching `InterruptedException`:
http://www.javapractices.com/topic/TopicAction.do?Id=251
We don't do anywhere else in our code which maybe not a good practice.
What do you think @BELUGABEHR ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
