[
https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812775#comment-16812775
]
Enrico Olivelli edited comment on ZOOKEEPER-3351 at 4/8/19 8:45 PM:
--------------------------------------------------------------------
most of the work of that script can be executed as part of normal Pull Request
validation using Maven plugins.
This is the complete list of checks:
* findbugs (superseded by spotbugs Maven plugin)
* checking javac warning (better to always compile with -Werrors flag, and
have 0 warnings)
* check for @autor tags (this is better to be checked with checkstyle,
[https://github.com/checkstyle/checkstyle/issues/5339])
* check javadoc warnings (it would be better to have 0 warnings)
* check for new tests in patch
* check Apache RAT (it is better to always have 0 warnings)
* run core java tests (to be run as usual)
* run contrib java tests (I am not sure it has some value, but we can run as
part of the full test suite on jenkins)
* add comment to Jira
was (Author: eolivelli):
most of the work of that script can be executed as part of normal Pull Request
validation.
This is the complete list of checks:
* findbugs (superseded by spotbugs Maven plugin)
* checking javac warning (better to always compile with -Werrors flag, and
have 0 warnings)
* check for @autor tags (this is better to be checked with checkstyle,
https://github.com/checkstyle/checkstyle/issues/5339)
* check javadoc warnings (it would be better to have 0 warnings)
* check for new tests in patch
* check Apache RAT (it is better to always have 0 warnings)
* run core java tests (to be run as usual)
* run contrib java tests (I am not sure it has some value, but we can run as
part of the full test suite on jenkins)
* add comment to Jira
> Migrate qa-test-pullrequest ant task to maven
> ---------------------------------------------
>
> Key: ZOOKEEPER-3351
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3351
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.5.5
> Reporter: Enrico Olivelli
> Assignee: Enrico Olivelli
> Priority: Major
> Fix For: 3.6.0
>
>
> In order to drop ANT we have to migrate task qa-test-pullrequest to Maven.
> That task is currently called this way in ASF Jenkins:
> {code:java}
> #!/bin/bash
> set +x
> #export JAVA_HOME=/home/jenkins/tools/java/jdk1.7.0-64
> export ANT_HOME=/home/jenkins/tools/ant/apache-ant-1.9.9
> #export PATH=$PATH:$JAVA_HOME/bin:$ANT_HOME/bin:
> export PATH=$PATH:$LATEST1_8_HOME/bin:$ANT_HOME/bin:
> export PATCH_DIR=${WORKSPACE}/patchprocess
> if [ ! -e "$PATCH_DIR" ] ; then
> mkdir -p $PATCH_DIR
> fi
> pwd
> git status
> git rev-parse HEAD
> which java
> java -version
> ulimit -a
> env
> ${ANT_HOME}/bin/ant \
> -Dpatch.file=foobar \
> -Dscratch.dir=$PATCH_DIR \
> -Dps.cmd=/bin/ps \
> -Dwget.cmd=/usr/bin/wget \
> -Djiracli.cmd=/home/jenkins/tools/jiracli/latest/jira.sh \
> -Dgit.cmd=/usr/bin/git \
> -Dgrep.cmd=/bin/grep \
> -Dpatch.cmd=/usr/bin/patch \
> -Dfindbugs.home=/home/jenkins/tools/findbugs/latest/ \
> -Dforrest.home=/home/jenkins/tools/forrest/latest/ \
> -Djira.passwd=xxxxxxxx \
> -Djava5.home=/home/jenkins/tools/java5/latest/ \
> -Dcurl.cmd=/usr/bin/curl \
> -Dtest.junit.maxmem=2g \
> qa-test-pullrequest{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
