eolivelli commented on a change in pull request #911: ZOOKEEPER-3365: Use
Concurrent HashMap in NettyServerCnxnFactory
URL: https://github.com/apache/zookeeper/pull/911#discussion_r275141402
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
##########
@@ -512,44 +511,34 @@ public InetSocketAddress getLocalAddress() {
return localAddress;
}
- private void addCnxn(NettyServerCnxn cnxn) {
+ private void addCnxn(final NettyServerCnxn cnxn) {
cnxns.add(cnxn);
- synchronized (ipMap){
- InetAddress addr =
-
((InetSocketAddress)cnxn.getChannel().remoteAddress()).getAddress();
- Set<NettyServerCnxn> s = ipMap.get(addr);
- if (s == null) {
- s = new HashSet<>();
- ipMap.put(addr, s);
+ InetAddress addr =
+ ((InetSocketAddress)
cnxn.getChannel().remoteAddress()).getAddress();
+
+ ipMap.compute(addr, (a, cnxnSet) -> {
+ if (cnxnSet == null) {
+ cnxnSet = new HashSet<>();
}
- s.add(cnxn);
- }
+ cnxnSet.add(cnxn);
Review comment:
You can do this out of the lambda, this way you will make the critical
section as small as possible
Or are you doing do in order not to synchronize explicitly on the Set which
is a raw HashSet?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
