+1 + checked signatures, checksum + tested cluster connectivity with 1,3,5 nodes non-TLS/TLS + run unit tests + code built + tested various 4lw commands + verified ACL checking
Regards, Andor > On 2019. Apr 15., at 15:54, Enrico Olivelli <[email protected]> wrote: > > +1 (non binding) > built and run tests (spotbugs, rat), on jdk11 + linux 64bit Fedora 28 > checksums/signatures ok > smoke tests on binary package with jdk8/11 on Fedora 28 > checked "lib" on binary packages/license stuff > > Great work ! > > Enrico > > > Il giorno lun 15 apr 2019 alle ore 15:06 Norbert Kalmar > <[email protected]> ha scritto: >> >> +1 (non-binding) >> >> Testing done with openjdk 1.8.0_163 on MacOS >> >> - signatures checked >> - license files checked >> >> source tarball testing: >> - built src package (mvn clean install) >> - unit tests passed >> - rat passed (mvn clean apache-rat:check) >> - spotBugs passed (mvn clean install -DskipTests spotbugs:check) >> - run the built binary (+ cli with basic commands) >> >> bin tarball testing: >> - run ZK from bin package (+ cli with basic commands) >> >> On Sun, Apr 14, 2019 at 3:52 PM Andor Molnar <[email protected]> wrote: >> >>> This is the first stable release of 3.5 branch: 3.5.5. It resolves 117 >>> issues, including Maven migration, Quorum TLS, TTL nodes and lots of other >>> performance and stability improvements. >>> >>> The full release notes is available at: >>> >>> >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12343268 >>> >>> *** Please download, test and vote by April 21st 2019, 23:59 UTC+0. *** >>> >>> Source files: >>> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.5.5-rc4/ >>> >>> Maven staging repos: >>> >>> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/parent/3.5.5/ >>> >>> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper-jute/3.5.5/ >>> >>> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.5.5/ >>> >>> The release candidate tag in git to be voted upon: release-3.5.5-rc4 >>> >>> ZooKeeper's KEYS file containing PGP keys we use to sign the release: >>> http://www.apache.org/dist/zookeeper/KEYS >>> >>> Should we release this candidate? >>> >>>
