[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820762#comment-16820762
 ] 

maoling commented on ZOOKEEPER-3350:
------------------------------------

[~Tison]

1. git log|grep -C 20 f1dd874ed7ddd42f006600319dd5e896ed8ac349
commit f1dd874ed7ddd42f006600319dd5e896ed8ac349
Author: Benjamin Reed <[email protected]>
Date: Tue Jun 3 15:51:18 2008 +0000
 [ 1913998 ] JMX instrumentation 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/trunk@670963 
13f79535-47bb-0310-9956-ffa450edef68

[~breed] may give us more info about this.
2. I prefer the refactor one,JMXConstants will have a more augmentability for 
placing more constants about JMX in the future.But moving  it as 
{{*MBeanRegistry.DOMAIN* is also a good option.}}

> Get rid of CommonNames
> ----------------------
>
>                 Key: ZOOKEEPER-3350
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3350
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: jmx
>    Affects Versions: 3.5.4
>            Reporter: TisonKun
>            Assignee: TisonKun
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.5.5
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Inside {{CommonNames}} it says {{TODO: will get rid of it eventually.}}.
> However, I don't see the reason of such removal and since it came from over 
> ten years ago I'd like to know whether it is still valid.
> cc [~phunt] [~anmolnar]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to