Norbert (and Andor) This is my patch for master, it must be adapted to 3.5 branch as we have a few more dependencies on 3.6 (snappy, dropwizard...) https://github.com/apache/zookeeper/pull/925
It includes a global fix up of poms, because as "zookeeper" pom imported junit, every other submodule that was using it didn't have to explicitly declare the dependency. See the other comments on the patch for the details. I think it is worth to commit it to master and fix 3.5.5 as well, now that we are doing our first Mavenized release Enrico Il giorno sab 27 apr 2019 alle ore 20:27 Enrico Olivelli <[email protected]> ha scritto: > > > > Il sab 27 apr 2019, 19:52 Norbert Kalmar <[email protected]> ha > scritto: >> >> It would be a nice thing to cleanup for sure. >> >> As we also have some test issues on another thread, I think theres a >> possibility for RC6? Anyway, if you can, definitely do the patch Enrico, it >> would be much appreciated! Even if there won't be a new RC, 3.5.6 will have >> it! > > > I think it is worth to try. > I will send a patch soon > > Enrico > >> >> Regards, >> Norbert >> >> On Sat, Apr 27, 2019 at 1:33 PM Enrico Olivelli <[email protected]> wrote: >> >> > Hi folks, >> > I am comparing the transitive dependencies that we will import to Java >> > clients with 3.5.5rc5 >> > >> > This is a dependency:tree of a simple application which imports >> > zookeeper-server:3.5.5 >> > >> > com.mycompany:ciaoZk:jar:1.0-SNAPSHOT >> > \- org.apache.zookeeper:zookeeper:jar:3.5.5:compile >> > +- org.apache.zookeeper:zookeeper-jute:jar:3.5.5:compile >> > +- commons-cli:commons-cli:jar:1.2:compile >> > +- org.apache.yetus:audience-annotations:jar:0.5.0:compile >> > +- io.netty:netty-all:jar:4.1.29.Final:compile >> > +- org.slf4j:slf4j-api:jar:1.7.25:compile >> > +- org.slf4j:slf4j-log4j12:jar:1.7.25:compile >> > +- org.eclipse.jetty:jetty-server:jar:9.4.15.v20190215:compile >> > | +- javax.servlet:javax.servlet-api:jar:3.1.0:compile >> > | +- org.eclipse.jetty:jetty-http:jar:9.4.15.v20190215:compile >> > | | \- org.eclipse.jetty:jetty-util:jar:9.4.15.v20190215:compile >> > | \- org.eclipse.jetty:jetty-io:jar:9.4.15.v20190215:compile >> > +- org.eclipse.jetty:jetty-servlet:jar:9.4.15.v20190215:compile >> > | \- org.eclipse.jetty:jetty-security:jar:9.4.15.v20190215:compile >> > +- com.fasterxml.jackson.core:jackson-databind:jar:2.9.8:compile >> > | +- com.fasterxml.jackson.core:jackson-annotations:jar:2.9.0:compile >> > | \- com.fasterxml.jackson.core:jackson-core:jar:2.9.8:compile >> > +- com.googlecode.json-simple:json-simple:jar:1.1.1:compile >> > | \- junit:junit:jar:4.10:compile >> > | \- org.hamcrest:hamcrest-core:jar:1.1:compile >> > +- jline:jline:jar:2.11:compile >> > \- log4j:log4j:jar:1.2.17:compile >> > >> > >> > and this one is for 3.5.4-beta >> > >> > com.mycompany:ciaoZk:jar:1.0-SNAPSHOT >> > \- org.apache.zookeeper:zookeeper:jar:3.5.4-beta:compile >> > +- org.slf4j:slf4j-api:jar:1.7.25:compile >> > +- org.slf4j:slf4j-log4j12:jar:1.7.25:compile >> > +- commons-cli:commons-cli:jar:1.2:compile >> > +- log4j:log4j:jar:1.2.17:compile >> > +- org.apache.yetus:audience-annotations:jar:0.5.0:compile >> > \- io.netty:netty:jar:3.10.6.Final:compile >> > >> > I am fine with importing more jetty stuff, and even jackson mapper >> > (but if we can drop them it would be better) >> > But I this that we should at least not have: >> > - junit >> > - hamcrest >> > >> > I feel this is kind of blocker for the release >> > >> > (for 3.6.0 I am working to a zookeeper client BOM which has only >> > client-side needed dependencies, but this is a different story) >> > >> > I can send a patch to fix 3.5.x >> > >> > Enrico >> >
